On Thu, 23 Jun 2022 16:12:31 GMT, Naoto Sato wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [2728770e](https://urldefense.com/v3/__https://github.com/openjdk/jdk/commit/2728770e3d73bb11c4d6e54b5aff91588a1a780b__;!!ACWV5N9M2RV99hQ!JWTXtcOlxAlKs1OamoE2hbweIBcqRBtUZoAQmPyrE
Hi all,
This pull request contains a backport of commit
[2728770e](https://urldefense.com/v3/__https://github.com/openjdk/jdk/commit/2728770e3d73bb11c4d6e54b5aff91588a1a780b__;!!ACWV5N9M2RV99hQ!N3mEnVUKBkymH2i4wvdNdT17pAtXF6773dQA7XG_uBo8CmAZNuaRhs6MMY2TvgGZ6WI7Xst8ex_Eul_yWGyTcg$
) from the [op
On Wed, 22 Jun 2022 17:41:45 GMT, Naoto Sato wrote:
> Done.
Thanks, that will be helpful if the test fails.
-
PR: https://git.openjdk.org/jdk/pull/9193
On Wed, 22 Jun 2022 17:46:58 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed
>> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE
>> mode based on the comment "should not hap
On Wed, 22 Jun 2022 10:48:47 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved `@Test` annotations
>
> test/jdk/java/nio/file/Files/ReadWriteString.java line 304:
>
>> 302: throws I
On Wed, 22 Jun 2022 10:50:56 GMT, Alan Bateman wrote:
> > > One other thing, this is a regression in 19 so I assume the PR should be
> > > against openjdk/jdk19 rather than the main line.
> >
> >
> > Since this PR already got a few approvals, I will backport the changeset to
> > the jdk19 lin
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen". Possibly this refers to the
> `String(byte[], int,
On Tue, 21 Jun 2022 21:49:58 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed
>> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE
>> mode based on the comment "should not hap
On Tue, 21 Jun 2022 18:23:35 GMT, Naoto Sato wrote:
> > One other thing, this is a regression in 19 so I assume the PR should be
> > against openjdk/jdk19 rather than the main line.
>
> Since this PR already got a few approvals, I will backport the changeset to
> the jdk19 line after this PR g
On Tue, 21 Jun 2022 20:59:40 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding a test case in ReadWriteString.java
>
> test/jdk/java/lang/String/NoReplTest.java line 47:
>
>> 45: privat
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen". Possibly this refers to the
> `String(byte[], int,
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen". Possibly this refers to the
> `String(byte[], int,
On Tue, 21 Jun 2022 18:12:23 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed
>> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE
>> mode based on the comment "should not hap
On Tue, 21 Jun 2022 08:55:09 GMT, Alan Bateman wrote:
> My comment was mostly asking if we need to add more tests for
> Files.writeString. I would have expected a test for that method to fail with
> this bug. Maybe we need to create a new issue to expand the tests for this
> method.
Added a t
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen". Possibly this refers to the
> `String(byte[], int,
On Sat, 18 Jun 2022 00:31:06 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed
>> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE
>> mode based on the comment "should not hap
On Sat, 18 Jun 2022 00:31:06 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed
>> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE
>> mode based on the comment "should not hap
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen". Possibly this refers to the
> `String(byte[], int,
On Fri, 17 Jun 2022 10:43:31 GMT, Alan Bateman wrote:
> Files.readString has been broken several times by the changes in to String in
> this area. Would it be possible to survey the tests that we have for this
> method, esp. the error cases, to see if we need more tests.
I looked for similar t
On Thu, 16 Jun 2022 22:21:23 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen"
On Thu, 16 Jun 2022 22:21:23 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen"
This is a regression caused by the fix to
[JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode based
on the comment "should not happen". Possibly this refers to the `String(byte[],
int, int, Chars
22 matches
Mail list logo
