Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v3]

2022-06-21 Thread Naoto Sato
On Tue, 21 Jun 2022 20:59:40 GMT, Andrey Turbanov wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding a test case in ReadWriteString.java > > test/jdk/java/lang/String/NoReplTest.java line 47: > >> 45: privat

Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v3]

2022-06-21 Thread Andrey Turbanov
On Tue, 21 Jun 2022 18:12:23 GMT, Naoto Sato wrote: >> This is a regression caused by the fix to >> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed >> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE >> mode based on the comment "should not hap

Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v3]

2022-06-21 Thread Naoto Sato
> This is a regression caused by the fix to > [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the > method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode > based on the comment "should not happen". Possibly this refers to the > `String(byte[], int,