Re: RFR: 8290353: Clarify the streams returned by ModuleReader::list [v2]

2022-07-19 Thread Chris Hegarty
On Mon, 18 Jul 2022 18:19:48 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull

Re: RFR: 8290353: Clarify the streams returned by ModuleReader::list [v2]

2022-07-19 Thread Chris Hegarty
On Mon, 18 Jul 2022 19:48:02 GMT, Mark Reinhold wrote: > It’s odd to mix adding some advice to the Javadoc with adopting that advice > in the code base. Consider opening a new issue and PR for the actual code > changes. [JDK-8290504][1] has been filed to track the implementation changes.

Re: RFR: 8290353: Clarify the streams returned by ModuleReader::list [v2]

2022-07-18 Thread Mark Reinhold
On Mon, 18 Jul 2022 18:19:48 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull

Re: RFR: 8290353: Clarify the streams returned by ModuleReader::list [v2]

2022-07-18 Thread Ryan Ernst
> This commit adds additional clarification to the javadocs of > ModuleReader::list about needing to close the stream. The new wording is > similar to that used in Files::find and other similar methods. Ryan Ernst has updated the pull request incrementally with two additional commits since the