> ### The Proposed Change
>
> The proposed change updates JNDI's `DnsClient` internal implementation to use
> `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
> The main motivation behind this change is to make JNDI/DNS lookups friendly
> to virtual-thread environments and upda
On Mon, 7 Nov 2022 15:41:40 GMT, Aleksei Efimov wrote:
>> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 185:
>>
>>> 183: public void close() {
>>> 184: try {
>>> 185: udpChannelSelector.close();
>>
>> Do you think we should now maintain a `closed`
On Mon, 7 Nov 2022 19:28:56 GMT, Aleksei Efimov wrote:
>> ### The Proposed Change
>>
>> The proposed change updates JNDI's `DnsClient` internal implementation to
>> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
>> The main motivation behind this change is to make JNDI/D
On Mon, 7 Nov 2022 15:39:55 GMT, Aleksei Efimov wrote:
>> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 470:
>>
>>> 468: } while (timeoutLeft > MIN_TIMEOUT);
>>> 469: // no matching packet received within the timeout
>>> 470:
On Mon, 7 Nov 2022 20:26:54 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DNSDatagramChannelFactory.java
> line 2
