Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops [v2]

2022-07-25 Thread Сергей Цыпанов
On Mon, 25 Jul 2022 06:40:49 GMT, Сергей Цыпанов wrote: >> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8278461: Revert X509CertPath I've m

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops [v2]

2022-07-24 Thread Сергей Цыпанов
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 8278461: Revert X509CertPath - Changes: - all: https://git.openjdk.org/jdk/pull/9596/fil

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-23 Thread Сергей Цыпанов
On Sat, 23 Jul 2022 18:10:15 GMT, Andrey Turbanov wrote: >> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. > > Ow. I've created similar PR for `X509CertPath` recently #9263 @turbanoff I'll then remove the mentioned piece from this PR - PR: https://git

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-23 Thread Andrey Turbanov
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote: > We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. Ow. I've created similar PR for `X509CertPath` recently #9263 - PR: https://git.openjdk.org/jdk/pull/9596

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-22 Thread Сергей Цыпанов
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote: > We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. Could one advise how to execute smth like `jmod hash --module-path ~/openjdk-18.0.2/Contents/Home/jmods --hash-modules .*`? This command doesn't work for me.

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-22 Thread Сергей Цыпанов
On Thu, 21 Jul 2022 21:14:44 GMT, Mark Reinhold wrote: > Please revise the summary to say “... instead of explicit loops”. Done. > Please measure this (using, e.g., [JMH](https://github.com/openjdk/jmh)) > before making such a change. I'm aware of JMH, I was asking mostly about public API I s