Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 12:47:13 GMT, Harold Seigel wrote: >> I think it should match the underlying representation else it may cause >> someone trying to debug a failure to look at the wrong part of the flags >> value, not realizing the printed value has the opposite format of the actual >> raw va

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote: >> I think it seems more natural to display the major version first, but I can >> change it if you prefer. > > I think it should match the underlying representation else it may cause > someone trying to debug a failure to look at the wrong pa

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
> Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw access flags. > > The fix was tested by running Mach5 ti