Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v2]

2022-08-26 Thread Roger Riggs
On Fri, 26 Aug 2022 17:02:36 GMT, Сергей Цыпанов wrote: >> src/java.base/share/native/libjava/io_util.c line 82: >> >>> 80:((*(buf + 1) & 0xFF) << 16) + >>> 81:((*(buf + 2) & 0xFF) << 8) + >>> 82:((*(buf + 3) & 0xFF)); >> >> What if the native byt

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v2]

2022-08-26 Thread Сергей Цыпанов
On Fri, 26 Aug 2022 16:39:01 GMT, Brian Burkhalter wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8292937: Move logic into VM side > > src/java.base/share/native/libjava/io_util.c line 82: > >> 80:

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v2]

2022-08-26 Thread Brian Burkhalter
On Fri, 26 Aug 2022 12:10:58 GMT, Сергей Цыпанов wrote: >> Currently some operations of RandomAccessFile are implemented with multiple >> read() invocations: >> >> public final int readInt() throws IOException { >> int ch1 = this.read(); >> int ch2 = this.read(); >> int ch3 = this.r

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v2]

2022-08-26 Thread Сергей Цыпанов
On Fri, 26 Aug 2022 12:56:50 GMT, Alan Bateman wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8292937: Move logic into VM side > > src/java.base/share/native/libjava/io_util.c line 71: > >> 69: jint nread =

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v2]

2022-08-26 Thread Alan Bateman
On Fri, 26 Aug 2022 12:10:58 GMT, Сергей Цыпанов wrote: >> Currently some operations of RandomAccessFile are implemented with multiple >> read() invocations: >> >> public final int readInt() throws IOException { >> int ch1 = this.read(); >> int ch2 = this.read(); >> int ch3 = this.r

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v2]

2022-08-26 Thread Сергей Цыпанов
> Currently some operations of RandomAccessFile are implemented with multiple > read() invocations: > > public final int readInt() throws IOException { > int ch1 = this.read(); > int ch2 = this.read(); > int ch3 = this.read(); > int ch4 = this.read(); > if ((ch1 | ch2 | ch3 |