Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Korov
On Thu, 7 Mar 2024 04:37:24 GMT, Chen Liang wrote: >> Korov has updated the pull request incrementally with one additional commit >> since the last revision: >> >> modify the code based on the review > > test/jdk/java/util/Collections/CheckedMapBash.java line 193: > >> 191: m.mer

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Chen Liang
On Thu, 7 Mar 2024 04:13:17 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > modify the code based on the rev

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Korov
On Thu, 7 Mar 2024 03:44:55 GMT, Guoxiong Li wrote: > Good caught. A trivial suggestion. Thanks for your suggestion, the code has been modified. - PR Comment: https://git.openjdk.org/jdk/pull/18141#issuecomment-1982318659

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Korov
> When the specified key did not associated with a value, should check the > `key` and `value` type. Korov has updated the pull request incrementally with one additional commit since the last revision: modify the code based on the review - Changes: - all: https://git.openjdk.o