RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-01 Thread Markus KARG
Fixes 8294541 - Commit messages: - Fixed 8294541 Changes: https://git.openjdk.org/jdk/pull/10524/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10524&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294541 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod Pat

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-03 Thread Brian Burkhalter
On Sat, 1 Oct 2022 17:54:37 GMT, Markus KARG wrote: > Fixes 8294541 This patch still failed on macOS: Seed from RandomFactory = 9174133304664648308L test TransferTo.testNullPointerException(): success test TransferTo.testStreamContents(): failure java.lang.OutOfMemoryError: Java heap space

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-04 Thread Markus KARG
On Sat, 1 Oct 2022 17:54:37 GMT, Markus KARG wrote: > Fixes 8294541 As the files are not zero'ed by intention (to detect differences), sparse won't help, so next you'd eventually run into quota trouble (IIRC we already had this a year ago). IMHO we should increase RAM a bit further (really, it

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-04 Thread Alan Bateman
On Tue, 4 Oct 2022 15:48:18 GMT, Markus KARG wrote: > As the files are not zero'ed by intention (to detect differences), sparse > won't help, so next you'd eventually run into quota trouble (IIRC we already > had this a year ago). IMHO we should increase RAM a bit further (really, it > is chea

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-08 Thread Markus KARG
On Sat, 1 Oct 2022 17:54:37 GMT, Markus KARG wrote: > Fixes 8294541 I increased `-Xmx` from 1G to 1.2G, and cannot reproduce the reported cases anymore. I gave it ten more random attempts which all passed, too. - PR: https://git.openjdk.org/jdk/pull/10524

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-08 Thread Alan Bateman
On Sat, 8 Oct 2022 21:40:37 GMT, Markus KARG wrote: > I increased `-Xmx` from 1G to 1.2G, and cannot reproduce the reported cases > anymore. I gave it ten more random attempts which all passed, too. I did some testing with this value and it does seem be enough. The alternative is to reduce MA

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME [v2]

2022-10-08 Thread Markus KARG
> Fixes 8294541 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: Fixed two more reported cases using 1.2 GiB - Changes: - all: https://git.openjdk.org/jdk/pull/10524/files - new: https://git.openjdk.org/jdk/pull/10524/

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME [v2]

2022-10-08 Thread Alan Bateman
On Sat, 8 Oct 2022 21:45:29 GMT, Markus KARG wrote: >> Fixes 8294541 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed two more reported cases using 1.2 GiB Marked as reviewed by alanb (Reviewer). - PR: ht

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME [v2]

2022-10-09 Thread Markus KARG
On Sat, 8 Oct 2022 21:45:29 GMT, Markus KARG wrote: >> Fixes 8294541 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed two more reported cases using 1.2 GiB Did a final test with `MIN_SIZE = 100_000_000` and it did pass