On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote:
> java.base java.lang.Module uses ASM to load module-info.class and this patch
> converts it to use Classfile API.
> It has been fixed by #12957
🤦
-
PR: https://git.openjdk.org/jdk/pull/11367
On Fri, 10 Mar 2023 09:16:03 GMT, Eirik Bjorsnos wrote:
> This PR seems to have broken `make docs`
It has been fixed by https://github.com/openjdk/jdk/pull/12957
-
PR: https://git.openjdk.org/jdk/pull/11367
On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote:
> java.base java.lang.Module uses ASM to load module-info.class and this patch
> converts it to use Classfile API.
This PR seems to have broken `make docs`:
Generating JDK_API javadoc for 60 modules
src/java.base/share/classes/java/lang/Mod
On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote:
> java.base java.lang.Module uses ASM to load module-info.class and this patch
> converts it to use Classfile API.
LGTM
-
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11367
On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote:
> java.base java.lang.Module uses ASM to load module-info.class and this patch
> converts it to use Classfile API.
This change looks good.
-
PR: https://git.openjdk.org/jdk/pull/11367
java.base java.lang.Module uses ASM to load module-info.class and this patch
converts it to use Classfile API.
-
Commit messages:
- Merge branch 'master' into JDK-8294959-module
- Merge branch 'JDK-8294982' into JDK-8294959
- removed obsolete javadoc from implementation classes
-
