On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incremen
On Thu, 9 Mar 2023 17:59:55 GMT, Mandy Chung wrote:
>> Yes, `Classfile::buildModule` contains logic determining if emission of
>> `ModulePackages` is required or not.
>
> It'd be helpful to add a comment that `ModulePackages` attribute is only
> emitted if there are packages that aren't exporte
On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incremen
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Mod
