Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 07:51:55 GMT, Adam Sotona wrote: >> make/modules/jdk.jartool/Java.gmk line 28: >> >>> 26: DISABLED_WARNINGS_java += missing-explicit-ctor >>> 27: JAVAC_FLAGS += -XDstringConcat=inline >>> 28: JAVAC_FLAGS += --enable-preview >> >> This change is no longer needed. It's not a

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 12:31:22 GMT, Adam Sotona wrote: >> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar >> entries >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target ba

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v4]

2023-03-10 Thread Adam Sotona
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar > entries > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 199