Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v16]

2023-09-15 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: adding

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v15]

2023-09-15 Thread Vicente Romero
On Fri, 15 Sep 2023 09:42:24 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v15]

2023-09-15 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixed

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v14]

2023-09-14 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

2023-09-14 Thread Adam Sotona
On Thu, 14 Sep 2023 16:38:36 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> applied suggested changes from review > > src/java.base/share/classes/jdk/internal/classfile/ClassReader.java line 184:

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

2023-09-14 Thread Brian Goetz
On Fri, 8 Sep 2023 10:15:26 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-08 Thread Adam Sotona
On Thu, 7 Sep 2023 03:10:33 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

2023-09-08 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: applied

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Vicente Romero
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v12]

2023-09-07 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 19:53:12 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 19:57:19 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 19:55:49 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-06 Thread Vicente Romero
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-06 Thread Vicente Romero
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-08-28 Thread Adam Sotona
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-07-27 Thread Adam Sotona
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-07-20 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v10]

2023-07-17 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v9]

2023-07-11 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixed code

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v8]

2023-06-30 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: added

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v7]

2023-06-30 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: extended

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v6]

2023-06-29 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v5]

2023-06-27 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v4]

2023-06-06 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v3]

2023-05-25 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v2]

2023-05-09 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

2023-04-17 Thread Adam Sotona
On Sat, 1 Apr 2023 20:31:05 GMT, Chen Liang wrote: > It's quite complicated to safeguard every potentially erroneous call. I agree, it is complicated, however possible. The question however is whether it is desirable. See for example silently failing `ClhsdbDumpclass` test with many

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

2023-04-17 Thread Chen Liang
On Tue, 29 Nov 2022 10:26:31 GMT, Adam Sotona wrote: > javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam I took a look at this patch locally; 4 of the javap tests fail. The

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

2023-04-17 Thread Adam Sotona
On Tue, 29 Nov 2022 10:26:31 GMT, Adam Sotona wrote: > javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam failing `hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java` test is

RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

2023-04-17 Thread Adam Sotona
javap uses proprietary com.sun.tools.classfile library to parse class files. This patch converts javap to use Classfile API. Please review. Thanks, Adam - Commit messages: - fixed TestClassNameWarning - Merge branch 'master' into JDK-8294969-javap - consolidated safeguarding of