Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v6]

2023-03-15 Thread Mandy Chung
On Wed, 15 Mar 2023 16:37:54 GMT, Adam Sotona wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 614: >> >>> 612: private void genConstructor(ClassBuilder clb) { >>> 613: clb.withMethod("", MethodTypeDesc.of(CD_void), >>>

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v6]

2023-03-15 Thread Adam Sotona
On Tue, 14 Mar 2023 16:34:59 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - long lines wrapped >> - StripJavaDebugAttributesPlugin transformation fixed >> - VersionPropsPlugin transformation f

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v6]

2023-03-14 Thread liach
On Tue, 14 Mar 2023 15:27:50 GMT, Adam Sotona wrote: >> jdk.jlink internal plugins are heavily using ASM >> >> This patch converts ASM calls to Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with three additional > commits sinc

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v6]

2023-03-14 Thread Adam Sotona
> jdk.jlink internal plugins are heavily using ASM > > This patch converts ASM calls to Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: - long lines wrapped - StripJavaDebugAttrib