Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-08 Thread Adam Sotona
On Tue, 7 Mar 2023 16:06:17 GMT, Paul Sandoz wrote: >> `Long:numberOfLeadingZeros` implementation uses more method calls, >> conditional statements and binary operations. I would prefer to stick with >> the current implementation for its speed and simplicity. > > `numberOfLeadingZeros` is an

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-07 Thread Paul Sandoz
On Tue, 7 Mar 2023 14:35:22 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line >> 176: >> >>> 174: } >>> 175: >>> 176: public static long nextPowerOfTwo( long x ) { >> >> If you like you can change the implementation to be: >> >> x

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-07 Thread Adam Sotona
On Fri, 3 Mar 2023 22:48:23 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 22:35:48 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Fri, 3 Mar 2023 23:12:17 GMT, Paul Sandoz

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 21:44:24 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 21:56:39 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.