> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Mon, 6 Mar 2023 17:11:42 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Mon, 6 Mar 2023 17:11:42 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Tue, 7 Mar 2023 11:14:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> snippets and tests synced with jdk.jfr class instrumentation source code
>
> src/java.base/share/classes/jdk/inte
On Tue, 7 Mar 2023 14:48:43 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line
>> 194:
>>
>>> 192: return (int)s;
>>> 193: }
>>> 194: }
>>
>> newline!
>
> Here I'm also not sure I understand, the long line has bee wrapped.
I mean
On Tue, 7 Mar 2023 15:48:22 GMT, Maurizio Cimadamore
wrote:
>> Here I'm also not sure I understand, the long line has bee wrapped.
>
> I mean here (and in the other) there seems to be a missing newline at the end
> of the file
OK, I'll fix it, thanks.
-
PR: https://git.openjdk.or
On Tue, 7 Mar 2023 15:48:58 GMT, Maurizio Cimadamore
wrote:
>> This is common practise across the whole implementation. Do you suggest to
>> remove all similar javadoc from all implementation classes?
>
> Well, if the javadoc simply states the name of the class it doesn't seem very
> useful. B
