Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Naoto Sato
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Lance Andersen
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Lance Andersen
On Mon, 24 Oct 2022 17:54:20 GMT, Brent Christian wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use data provider for getBundle test > > test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 81: > >> 7

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Brent Christian
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix