Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-26 Thread David Holmes
On Thu, 13 Oct 2022 14:48:29 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-26 Thread David Holmes
On Wed, 26 Jul 2023 04:31:13 GMT, Sergey Bylokhov wrote: >> Thank you! >> >>>If processing string specifier s, S, or Z, format specification processing >>>stops, a NULL is placed at the beginning of the buffer. >> >> I hope this is not an MS extension/implementation detail since I did not >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-25 Thread Sergey Bylokhov
On Tue, 25 Jul 2023 23:51:34 GMT, Sergey Bylokhov wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-25 Thread David Holmes
On Tue, 25 Jul 2023 23:51:34 GMT, Sergey Bylokhov wrote: > I hope this is not an MS extension/implementation detail since I did not find > this in any other places. @mrserb this change was to a Windows specific file. - PR Comment:

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-25 Thread Sergey Bylokhov
On Thu, 13 Oct 2022 14:48:29 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2023-07-25 Thread Julian Waters
On Tue, 25 Jul 2023 21:00:17 GMT, Sergey Bylokhov wrote: >> @dholmes-ora could I trouble you for a sponsor? Thanks! > > @TheShermanTanker Working on a similar cleanup, and wonder if is it correct > to assume that the "snprintf" adds "nul" even in case of error. > For example, this code was

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2023-07-25 Thread Sergey Bylokhov
On Thu, 13 Oct 2022 14:34:25 GMT, Julian Waters wrote: >> Looks good. Thanks. > > @dholmes-ora could I trouble you for a sponsor? Thanks! @TheShermanTanker Working on a similar cleanup, and wonder if is it correct to assume that the "snprintf" adds "nul" even in case of error. For example,

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-13 Thread Julian Waters
On Tue, 11 Oct 2022 02:01:12 GMT, David Holmes wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2022-10-13 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v4]

2022-10-12 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-10 Thread David Holmes
On Mon, 10 Oct 2022 11:59:55 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-10 Thread Kim Barrett
On Mon, 10 Oct 2022 11:59:55 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-10 Thread Julian Waters
On Mon, 10 Oct 2022 05:06:00 GMT, David Holmes wrote: >> src/java.base/share/native/libjli/jli_util.h line 91: >> >>> 89: * https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference >>> 90: * /snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170 >>> 91: */ >> >> I don't

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-10 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread David Holmes
On Sun, 9 Oct 2022 17:58:37 GMT, Kim Barrett wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment formatting > > src/java.base/share/native/libjli/jli_util.h line 91: > >> 89: *

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread David Holmes
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread Kim Barrett
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf

2022-10-09 Thread Julian Waters
The C99 snprintf is available with Visual Studio 2015 and above, alongside Windows 10 and the UCRT, and is no longer identical to the outdated Windows _snprintf. Since support for the Visual C++ 2017 compiler was removed a while ago, we can now safely remove the compatibility workaround on