Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-26 Thread David Holmes
On Thu, 13 Oct 2022 14:48:29 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-26 Thread David Holmes
On Wed, 26 Jul 2023 04:31:13 GMT, Sergey Bylokhov wrote: >> Thank you! >> >>>If processing string specifier s, S, or Z, format specification processing >>>stops, a NULL is placed at the beginning of the buffer. >> >> I hope this is not an MS extension/implementation detail since I did not >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-25 Thread Sergey Bylokhov
On Tue, 25 Jul 2023 23:51:34 GMT, Sergey Bylokhov wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-25 Thread David Holmes
On Tue, 25 Jul 2023 23:51:34 GMT, Sergey Bylokhov wrote: > I hope this is not an MS extension/implementation detail since I did not find > this in any other places. @mrserb this change was to a Windows specific file. - PR Comment:

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2023-07-25 Thread Sergey Bylokhov
On Thu, 13 Oct 2022 14:48:29 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2022-10-13 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround