Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Erik Joelsson
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Andy Goryachev
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote: > replace those dangling white spaces with explicit Unicode escapes this is a *very good* idea. - PR: https://git.openjdk.org/jdk/pull/10792

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-23 Thread Phil Race
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas