RFR: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows

2023-01-12 Thread Naoto Sato
Fixing a regression caused by the fix to [JDK-8298971](https://bugs.openjdk.org/browse/JDK-8298971). The previous fix lacked the native part change on Windows. - Commit messages: - 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows Changes: https:

Re: RFR: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows

2023-01-13 Thread Alan Bateman
On Thu, 12 Jan 2023 17:08:29 GMT, Naoto Sato wrote: > Fixing a regression caused by the fix to > [JDK-8298971](https://bugs.openjdk.org/browse/JDK-8298971). The previous fix > lacked the native part change on Windows. I think we should try to have a cleaner separation between these native met

Re: RFR: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows

2023-01-13 Thread Naoto Sato
On Fri, 13 Jan 2023 14:12:36 GMT, Alan Bateman wrote: > I think we should try to have a cleaner separation between these native > methods. If JdkConsoleImpl_echo is changed to call > GetStdHandle(STD_INPUT_HANDLE) then it would avoid needing Console_md to > export java_io_Console_hStdIn. It wo

Re: RFR: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows [v2]

2023-01-13 Thread Naoto Sato
> Fixing a regression caused by the fix to > [JDK-8298971](https://bugs.openjdk.org/browse/JDK-8298971). The previous fix > lacked the native part change on Windows. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Avoid sharing stdin

Re: RFR: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows [v2]

2023-01-14 Thread Alan Bateman
On Fri, 13 Jan 2023 19:18:46 GMT, Naoto Sato wrote: >> Fixing a regression caused by the fix to >> [JDK-8298971](https://bugs.openjdk.org/browse/JDK-8298971). The previous fix >> lacked the native part change on Windows. > > Naoto Sato has updated the pull request incrementally with one additio