Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators [v2]

2023-05-24 Thread Paul Sandoz
On Wed, 24 May 2023 17:09:23 GMT, Maurizio Cimadamore wrote: >> There is a difference in behavior between `System::loadLibrary` and >> `SymbolLookup::libraryLookup(String)`. While the former catches library >> names containing NULL chars (because, internally it uses Path/File logic, >> which

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators [v2]

2023-05-24 Thread Maurizio Cimadamore
> There is a difference in behavior between `System::loadLibrary` and > `SymbolLookup::libraryLookup(String)`. While the former catches library names > containing NULL chars (because, internally it uses Path/File logic, which > reject those), `SymbolLookup` does not. As a result, it is possible

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators

2023-05-24 Thread Maurizio Cimadamore
On Wed, 24 May 2023 16:30:25 GMT, Paul Sandoz wrote: > Do you also need to test on `SymbolLookup` returned from > `Linker::defaultLookup`? Yeah - some test would be better. - PR Comment: https://git.openjdk.org/jdk/pull/14126#issuecomment-1561568364

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators

2023-05-24 Thread Paul Sandoz
On Wed, 24 May 2023 15:22:15 GMT, Maurizio Cimadamore wrote: > There is a difference in behavior between `System::loadLibrary` and > `SymbolLookup::libraryLookup(String)`. While the former catches library names > containing NULL chars (because, internally it uses Path/File logic, which >

RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators

2023-05-24 Thread Maurizio Cimadamore
There is a difference in behavior between `System::loadLibrary` and `SymbolLookup::libraryLookup(String)`. While the former catches library names containing NULL chars (because, internally it uses Path/File logic, which reject those), `SymbolLookup` does not. As a result, it is possible to load