Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-25 Thread Ichiroh Takiguchi
On Fri, 24 Feb 2023 17:19:22 GMT, Naoto Sato wrote: >> Hello @naotoj . >> Sorry for bothering you. >> >> I have following question: >> - Why GB18030.java.template is in >> src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the >> generated code is always stored into sun/nio/cs ?

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Naoto Sato
On Fri, 24 Feb 2023 08:34:48 GMT, Ichiroh Takiguchi wrote: > Hello @naotoj . Sorry for bothering you. > > I have following question: > > * Why GB18030.java.template is in > src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the > generated code is always stored into sun/nio/cs

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Alan Bateman
On Fri, 24 Feb 2023 08:34:48 GMT, Ichiroh Takiguchi wrote: > * Why GB18030.java.template is in > src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the > generated code is always stored into sun/nio/cs ? That is a good question. It could move, and $PACKAGE replaced with sun.nio.

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Sean Coffey
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping f

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Ichiroh Takiguchi
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping f

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-23 Thread Alan Bateman
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping f

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-23 Thread Naoto Sato
On Thu, 23 Feb 2023 10:07:22 GMT, Alan Bateman wrote: >> would use of jdk.internal.util.SystemProps be an option here (if having to >> retrieve that value when we're at VM init level <1 ? > >> would use of jdk.internal.util.SystemProps be an option here (if having to >> retrieve that value when

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-23 Thread Naoto Sato
> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls back to the existing mapping based on the 2000 standa