On Fri, 23 Jun 2023 22:02:22 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/util/resources/Bundles.java line 510:
>>
>>> 508: return false;
>>> 509: }
>>> 510: return Objects.equals(locale, otherEntry.locale)
>>
>> While the
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Fri, 23 Jun 2023 21:59:21 GMT, Pavel Rappo wrote:
> NPE was seemingly caught to cover for other being null.
Unlike that of other file in this PR.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/12328#discussion_r1240446275
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Fri, 23 Jun 2023 17:05:19 GMT, Naoto Sato wrote:
>> I'll run our CI, and if all good, I'll approve this PR. If nothing else,
>> this change seems reasonable and correct.
>
> Thanks Pavel for jumping in. I too think this change looks good.
Yep; all good.
-
PR Review Comment:
On Fri, 23 Jun 2023 15:11:47 GMT, Pavel Rappo wrote:
>> Yes:
>>
>> CacheKey(String baseName, Locale locale, Module module, Module caller) {
>> Objects.requireNonNull(module);
>> Objects.requireNonNull(caller);
>>
>> this.name = baseName;
>> this.locale = locale;
>>
On Fri, 23 Jun 2023 13:46:04 GMT, Sergey Tsypanov wrote:
>> src/java.base/share/classes/java/util/ResourceBundle.java line 743:
>>
>>> 741: return ((module != null) &&
>>> (module.equals(otherEntry.getModule())) &&
>>> 742: (caller != null) &&
>>>
On Fri, 23 Jun 2023 10:41:49 GMT, Pavel Rappo wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore logic
>
> src/java.base/share/classes/java/util/ResourceBundle.java line 743:
>
>> 741:
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
> outdated. This simple clean-up modernizes them.
Sergey Tsypanov has updated the pull request incrementally with one additional
commit since the last revision:
Restore logic
-
Changes:
- all:
16 matches
Mail list logo
