Re: RFR: 8302877: Speed up latin1 case conversions [v2]

2023-02-21 Thread Eirik Bjorsnos
On Tue, 21 Feb 2023 10:29:24 GMT, Claes Redestad wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Spell fix for 'exhaustive' in comments in sun/text/resources > >

Re: RFR: 8302877: Speed up latin1 case conversions [v2]

2023-02-21 Thread Claes Redestad
On Tue, 21 Feb 2023 06:59:47 GMT, Eirik Bjorsnos wrote: >> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase >> for latin1 code points by applying the 'oldest ASCII trick in the book'. >> >> This takes advantage of the fact that latin1 uppercase code points are >>

Re: RFR: 8302877: Speed up latin1 case conversions [v2]

2023-02-21 Thread Eirik Bjorsnos
On Tue, 21 Feb 2023 09:33:07 GMT, Eirik Bjorsnos wrote: > I have the feeling that most case-insensitive comparisons are pretty short, > so not sure how useful this is IRL. There seems to be a win from strings of size 32 bytes upwards. (That's probably longer than most keys in TreeMaps using

Re: RFR: 8302877: Speed up latin1 case conversions [v2]

2023-02-21 Thread Eirik Bjorsnos
On Tue, 21 Feb 2023 06:59:47 GMT, Eirik Bjorsnos wrote: >> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase >> for latin1 code points by applying the 'oldest ASCII trick in the book'. >> >> This takes advantage of the fact that latin1 uppercase code points are >>

Re: RFR: 8302877: Speed up latin1 case conversions [v2]

2023-02-21 Thread Eirik Bjorsnos
On Tue, 21 Feb 2023 00:14:20 GMT, Naoto Sato wrote: >> I did an 'exchaustive' search for 'exchaustive' across the code base and >> found two comments in `LocaleData` and `LocaleData.cldr` in >> `jdk/test/jdk/sun/text/resources`. >> >> Would you like me to update these as well while we're

Re: RFR: 8302877: Speed up latin1 case conversions [v2]

2023-02-20 Thread Eirik Bjorsnos
> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase > for latin1 code points by applying the 'oldest ASCII trick in the book'. > > This takes advantage of the fact that latin1 uppercase code points are always > 0x20 lower than their lowercase (with the exception of