On Tue, 28 Feb 2023 07:49:17 GMT, Madjosz wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> Madjosz has updated the pull request incrementally with one additional commit
> since the last revision:
>
> whitespace, remove stream()
Marked as reviewed by naoto (Reviewer).
On Tue, 28 Feb 2023 07:49:17 GMT, Madjosz wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> Madjosz has updated the pull request incrementally with one additional commit
> since the last revision:
>
> whitespace, remove stream()
Is this ready to merge now?
-
PR
> Fixes JDK-8302983 (and duplicate JDK-8302898)
Madjosz has updated the pull request incrementally with one additional commit
since the last revision:
whitespace, remove stream()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12690/files
- new:
On Sat, 25 Feb 2023 00:07:45 GMT, Madjosz wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> Madjosz has refreshed the contents of this pull request, and previous commits
> have been removed. The incremental views will show differences compared to
> the previous content of the PR. The
> Fixes JDK-8302983 (and duplicate JDK-8302898)
Madjosz has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
last
On Fri, 24 Feb 2023 19:52:59 GMT, Madjosz wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> Madjosz has updated the pull request incrementally with one additional commit
> since the last revision:
>
> apply review comments
Changes requested by naoto (Reviewer).
On Fri, 24 Feb 2023 19:35:29 GMT, Madjosz wrote:
>> test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 123:
>>
>>> 121: ZoneRulesProvider.registerProvider(provider);
>>> 122: assertTrue(ZoneId.getAvailableZoneIds().contains(zone),
>>> "Unexpected
> Fixes JDK-8302983 (and duplicate JDK-8302898)
Madjosz has updated the pull request incrementally with one additional commit
since the last revision:
apply review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12690/files
- new:
On Wed, 22 Feb 2023 20:41:07 GMT, Naoto Sato wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 123:
>
>> 121: ZoneRulesProvider.registerProvider(provider);
>> 122:
On Tue, 21 Feb 2023 13:44:52 GMT, Madjosz wrote:
> Fixes JDK-8302983 (and duplicate JDK-8302898)
Thanks for fixing this. Some comments follow.
test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 43:
> 41: /**
> 42: * @summary Tests for ZoneRulesProvider class.
> 43: *
Fixes JDK-8302983 (and duplicate JDK-8302898)
-
Commit messages:
- 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
Changes: https://git.openjdk.org/jdk/pull/12690/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=12690=00
Issue:
11 matches
Mail list logo