Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v4]

2023-04-21 Thread Naoto Sato
On Tue, 28 Feb 2023 07:49:17 GMT, Madjosz wrote: >> Fixes JDK-8302983 (and duplicate JDK-8302898) > > Madjosz has updated the pull request incrementally with one additional commit > since the last revision: > > whitespace, remove stream() Marked as reviewed by naoto (Reviewer).

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v4]

2023-04-21 Thread Madjosz
On Tue, 28 Feb 2023 07:49:17 GMT, Madjosz wrote: >> Fixes JDK-8302983 (and duplicate JDK-8302898) > > Madjosz has updated the pull request incrementally with one additional commit > since the last revision: > > whitespace, remove stream() Is this ready to merge now? - PR

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v4]

2023-02-27 Thread Madjosz
> Fixes JDK-8302983 (and duplicate JDK-8302898) Madjosz has updated the pull request incrementally with one additional commit since the last revision: whitespace, remove stream() - Changes: - all: https://git.openjdk.org/jdk/pull/12690/files - new:

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v3]

2023-02-25 Thread Andrey Turbanov
On Sat, 25 Feb 2023 00:07:45 GMT, Madjosz wrote: >> Fixes JDK-8302983 (and duplicate JDK-8302898) > > Madjosz has refreshed the contents of this pull request, and previous commits > have been removed. The incremental views will show differences compared to > the previous content of the PR. The

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v3]

2023-02-24 Thread Madjosz
> Fixes JDK-8302983 (and duplicate JDK-8302898) Madjosz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v2]

2023-02-24 Thread Naoto Sato
On Fri, 24 Feb 2023 19:52:59 GMT, Madjosz wrote: >> Fixes JDK-8302983 (and duplicate JDK-8302898) > > Madjosz has updated the pull request incrementally with one additional commit > since the last revision: > > apply review comments Changes requested by naoto (Reviewer).

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v2]

2023-02-24 Thread Madjosz
On Fri, 24 Feb 2023 19:35:29 GMT, Madjosz wrote: >> test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 123: >> >>> 121: ZoneRulesProvider.registerProvider(provider); >>> 122: assertTrue(ZoneId.getAvailableZoneIds().contains(zone), >>> "Unexpected

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v2]

2023-02-24 Thread Madjosz
> Fixes JDK-8302983 (and duplicate JDK-8302898) Madjosz has updated the pull request incrementally with one additional commit since the last revision: apply review comments - Changes: - all: https://git.openjdk.org/jdk/pull/12690/files - new:

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider

2023-02-24 Thread Madjosz
On Wed, 22 Feb 2023 20:41:07 GMT, Naoto Sato wrote: >> Fixes JDK-8302983 (and duplicate JDK-8302898) > > test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 123: > >> 121: ZoneRulesProvider.registerProvider(provider); >> 122:

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider

2023-02-22 Thread Naoto Sato
On Tue, 21 Feb 2023 13:44:52 GMT, Madjosz wrote: > Fixes JDK-8302983 (and duplicate JDK-8302898) Thanks for fixing this. Some comments follow. test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 43: > 41: /** > 42: * @summary Tests for ZoneRulesProvider class. > 43: *

RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider

2023-02-21 Thread Madjosz
Fixes JDK-8302983 (and duplicate JDK-8302898) - Commit messages: - 8302983: ZoneRulesProvider.registerProvider() twice will remove provider Changes: https://git.openjdk.org/jdk/pull/12690/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12690=00 Issue: