On Mon, 22 May 2023 14:09:22 GMT, Martin Doerr wrote:
>> Yes, good idea.
>
> Please take a look at
> https://github.com/openjdk/jdk/pull/12708/commits/70736be631e4f1bf3fd3c0d45ddfc076b74ef9dd
It looks good.
-
PR Review Comment:
On Mon, 22 May 2023 13:59:05 GMT, Richard Reingruber wrote:
>> Or better `final boolean useABIv2 = (this instanceof ABIv2CallArranger);`
>
> Yes, good idea.
Please take a look at
https://github.com/openjdk/jdk/pull/12708/commits/70736be631e4f1bf3fd3c0d45ddfc076b74ef9dd
-
PR
On Mon, 22 May 2023 13:42:27 GMT, Martin Doerr wrote:
>> Probably, yes. I didn't find time for figuring out what would be useful
>> tests. We could still add some in the future or with the big endian port.
>> Another idea: Would the following be better?
>> `final boolean useABIv2 =
On Mon, 22 May 2023 13:34:49 GMT, Martin Doerr wrote:
>>> That would be better to read, but would make the PPC64 CallArranger
>>> dependent on the current CABI. Note that there are tests which use
>>>
>>> ```
>>> import jdk.internal.foreign.abi.aarch64.CallArranger;
>>> ...
>>>
On Mon, 22 May 2023 13:29:14 GMT, Richard Reingruber wrote:
>> That would be better to read, but would make the PPC64 CallArranger
>> dependent on the current CABI.
>> Note that there are tests which use
>>
>> import jdk.internal.foreign.abi.aarch64.CallArranger;
>> ...
>>
On Mon, 22 May 2023 12:38:23 GMT, Martin Doerr wrote:
> That would be better to read, but would make the PPC64 CallArranger dependent
> on the current CABI. Note that there are tests which use
>
> ```
> import jdk.internal.foreign.abi.aarch64.CallArranger;
> ...
>
On Mon, 22 May 2023 12:14:48 GMT, Richard Reingruber wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java
>> line 65:
>>
>>> 63: */
>>> 64: public abstract class CallArranger {
>>> 65: protected abstract boolean useABIv2();
>>
>> This could also be
On Mon, 22 May 2023 08:53:21 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup imports, improve comments, updates from other platforms.
>
>
On Fri, 19 May 2023 18:54:19 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by
10 matches
Mail list logo
