Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-05-05 Thread Quan Anh Mai
On Tue, 25 Apr 2023 11:59:30 GMT, Jatin Bhateja wrote: >> src/hotspot/share/opto/vectorIntrinsics.cpp line 1914: >> >>> 1912: if (vector_klass->const_oop() == NULL || elem_klass->const_oop() == >>> NULL || >>> 1913: !vlen->is_con() || !origin_type->is_con()) { >>> 1914: if (C->print

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-05-05 Thread Quan Anh Mai
On Tue, 11 Apr 2023 19:03:21 GMT, Vladimir Ivanov wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> style > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java > line 2295: > >> 2293:

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-05-05 Thread Quan Anh Mai
On Thu, 6 Apr 2023 01:45:37 GMT, Xiaohong Gong wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> style > > test/hotspot/jtreg/compiler/vectorapi/TestVectorSlice.java line 466: > >> 464: @IR(counts = {IRNode.VECT

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-25 Thread Jatin Bhateja
On Tue, 25 Apr 2023 11:57:21 GMT, Jatin Bhateja wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> style > > src/hotspot/share/opto/vectorIntrinsics.cpp line 1914: > >> 1912: if (vector_klass->const_oop() == NULL |

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-25 Thread Jatin Bhateja
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-12 Thread Eric Liu
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-11 Thread Vladimir Ivanov
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v5]

2023-04-05 Thread Xiaohong Gong
On Tue, 4 Apr 2023 13:24:18 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-05 Thread Xiaohong Gong
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-04 Thread Paul Sandoz
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v4]

2023-04-04 Thread Quan Anh Mai
On Mon, 3 Apr 2023 16:36:08 GMT, Paul Sandoz wrote: >> Quan Anh Mai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - instruction asserts >> - Merge branch 'master' into sliceIntrinsics >> - add comments expl

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-04 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v5]

2023-04-04 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v4]

2023-04-03 Thread Xiaohong Gong
On Sat, 1 Apr 2023 07:44:25 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v4]

2023-04-03 Thread Paul Sandoz
On Sat, 1 Apr 2023 07:44:25 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v4]

2023-04-02 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v2]

2023-03-08 Thread Quan Anh Mai
On Wed, 8 Mar 2023 16:23:16 GMT, Paul Sandoz wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address reviews > > Java changes look good. The HotSpot code looks well structured but i will let > others comment on th

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v3]

2023-03-08 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v2]

2023-03-08 Thread Paul Sandoz
On Wed, 8 Mar 2023 13:46:03 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v2]

2023-03-08 Thread Paul Sandoz
On Wed, 8 Mar 2023 13:48:16 GMT, Quan Anh Mai wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java >> line 2289: >> >>> 2287: getClass(), byte.class, length(), >>> 2288: this, that, origin, >>> 2289: new VectorSliceOp() { >>

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v2]

2023-03-08 Thread Quan Anh Mai
On Wed, 8 Mar 2023 00:29:05 GMT, Paul Sandoz wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address reviews > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java > line 2289: > >> 2287:

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v2]

2023-03-08 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice

2023-03-07 Thread Paul Sandoz
On Tue, 7 Mar 2023 18:23:42 GMT, Quan Anh Mai wrote: > `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice

2023-03-07 Thread Paul Sandoz
On Tue, 7 Mar 2023 18:23:42 GMT, Quan Anh Mai wrote: > `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice

2023-03-07 Thread Quan Anh Mai
On Tue, 7 Mar 2023 18:23:42 GMT, Quan Anh Mai wrote: > `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion

RFR: 8303762: [vectorapi] Intrinsification of Vector.slice

2023-03-07 Thread Quan Anh Mai
`Vector::slice` is a method at the top-level class of the Vector API that concatenates the 2 inputs into an intermediate composite and extracts a window equal to the size of the inputs into the result. It is used in vector conversion methods where the part number is not 0 to slice the parts to t