Re: RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]

2023-03-13 Thread Jaikiran Pai
On Mon, 13 Mar 2023 21:02:51 GMT, Adam Sotona wrote: >> jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised >> parallel junit tests >> >> The root cause seems to be thread-unsafe lazy initialisation of >> `TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArrayCode`. Provid

Re: RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]

2023-03-13 Thread liach
On Mon, 13 Mar 2023 21:02:51 GMT, Adam Sotona wrote: >> jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised >> parallel junit tests >> >> The root cause seems to be thread-unsafe lazy initialisation of >> `TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArrayCode`. Provid

Re: RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]

2023-03-13 Thread Adam Sotona
> jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised parallel > junit tests > > The root cause seems to be thread-unsafe lazy initialisation of > `TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArrayCode`. Provided > patch replaces that lazy-initialized helper array with

Re: RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]

2023-03-13 Thread Adam Sotona
On Mon, 13 Mar 2023 19:04:45 GMT, liach wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> throwing IllegalArgumentException instead of IllegalStateException > > src/java.base/share/classes/jdk/internal/classfile/TypeK