On Sun, 19 Mar 2023 09:07:41 GMT, Alan Bateman wrote:
>> Hello Mandy, Alan, Jim,
>>
>> I've updated this PR to take into account these suggestions. I went ahead
>> with what Mandy suggested and enhanced the existing (internal)
>> `jdk.tools.jlink.internal.Platform` `record`to additional parse
On Sat, 18 Mar 2023 13:28:52 GMT, Jaikiran Pai wrote:
>>> `Platform::parsePlatform` is the utility method to parse `ModuleTarget`. It
>>> can be updated to include additional architectures.
>>
>> Alternatively, don't parse it. If we go with Jim's suggestion of a resource
>> file then it is jus
On Mon, 13 Mar 2023 23:20:35 GMT, Mandy Chung wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> don't hardcode the .jmod extension while determining java.base module
>> location
>
> src/jdk.jlink/share/classes/jdk/t
On Tue, 14 Mar 2023 08:30:11 GMT, Alan Bateman wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 953:
>>
>>> 951: // and supported for creating an image through jlink. Else
>>> returns null.
>>> 952: private static ByteOrder
>>> getNativeEndianO
On Mon, 13 Mar 2023 23:07:13 GMT, Mandy Chung wrote:
> `Platform::parsePlatform` is the utility method to parse `ModuleTarget`. It
> can be updated to include additional architectures.
Alternatively, don't parse it. If we go with Jim's suggestion of a resource
file then it is just a simple map
On Mon, 13 Mar 2023 16:22:30 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
