On Wed, 15 Nov 2023 07:41:32 GMT, Jaikiran Pai wrote:
> Overall, this is a very good improvement to the test and looks good to me. I
> just a have a trivial comment about a typo in a code comment, which I've
> added inline.
Thanks for your review, Jaikiran! With these latest, comment-only
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested is the validation that the total CEN size fits in a Java
> byte array. Suggested rename: CenSizeTooLarge
