On Wed, 8 Nov 2023 13:54:23 GMT, Eirik Bjorsnos wrote:
> > > > I think the changes look good overall. Thank you for this. I am not
> > > > sure that the `@requires` is needed at this point.
> > >
> > >
> > > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the
> > > 8GB memo
On Mon, 30 Oct 2023 14:29:41 GMT, Lance Andersen wrote:
> > > I think the changes look good overall. Thank you for this. I am not sure
> > > that the `@requires` is needed at this point.
> >
> >
> > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB
> > memory requirem
On Mon, 30 Oct 2023 14:29:41 GMT, Lance Andersen wrote:
> > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB
> > memory requirement? If so, I guess we can safely remove the requires tag,
> > even though the test still creates a ~2GB sparse file?
>
> We would have to r
On Mon, 30 Oct 2023 12:13:59 GMT, Eirik Bjorsnos wrote:
> > I think the changes look good overall. Thank you for this. I am not sure
> > that the `@requires` is needed at this point.
>
> Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB
> memory requirement? If so, I g
On Sun, 12 Mar 2023 11:21:18 GMT, Eirik Bjorsnos wrote:
> I think the changes look good overall. Thank you for this. I am not sure that
> the `@requires` is needed at this point.
Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB
memory requirement? If so, I guess we ca
On Sun, 12 Mar 2023 14:12:08 GMT, Lance Andersen wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use Integer.toString instead of Long.toString
>
>> Here's a wild idea:
>>
>> We could inject large extra fields on
On Sun, 12 Mar 2023 14:12:08 GMT, Lance Andersen wrote:
> I think this is probably OK. I would probably create a constant with the Data
> Size to make it clearer and add more of a detailed comment of this method
> (laying out the structure of the Extra field) along with pointing to 4.6.1 of
>
On Sun, 12 Mar 2023 16:41:33 GMT, Martin Buchholz wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use Integer.toString instead of Long.toString
>
> test/jdk/java/util/zip/ZipFile/CenSizeTooLarge.java line 67:
>
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Sun, 12 Mar 2023 11:47:47 GMT, Alan Bateman wrote:
> It would be great if we could change this to be an automatic test. Maybe we
> could create a sub-directory in test/jdk/java/util/zip/ZipFile for the
> resource hogs and put this here, exclude this directory from tier1, and add
> it to tie
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Sun, 12 Mar 2023 11:13:51 GMT, Lance Andersen wrote:
> I think the changes look good overall. Thank you for this. I am not sure that
> the `@requires` is needed at this point.
I think it is still needed. ZipOutputStream needs to keep all entries in memory
until it can write the CEN entries.
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested here is the validation that the total CEN size fits in a
> Java byte array. Suggested rename: CenSizeTooL
16 matches
Mail list logo
