> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested is the validation that the total CEN size fits in a Java
> byte array. Suggested rename: CenSizeTooLarge
On Sun, 12 Mar 2023 21:25:46 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Mon, 13 Mar 2023 01:31:20 GMT, Martin Buchholz wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - MAX_EXTRA_FIELD_SIZE can be better expressed as 0x
>> - Bring back '@requires sun.arch.data.model == 64' fo
On Sun, 12 Mar 2023 21:25:46 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Mon, 13 Mar 2023 03:18:26 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/ZipFile/CenSizeTooLarge.java line 53:
>>
>>> 51:
>>> 52: // Maximum size (unsigned short) of an extra field allowed by the
>>> standard
>>> 53: static final int MAX_EXTRA_FIELD_SIZE = 0X;
>>
>> 4.4.1
