Re: RFR: 8304717: Declaration aliasing between boolean and jboolean is wrong [v3]

2023-04-08 Thread Julian Waters
On Fri, 31 Mar 2023 05:57:01 GMT, Julian Waters wrote: >> A couple of spots wrongly refer to boolean and jboolean as the same thing. >> While this does still compile thanks to a happy accident and implicit >> conversions, they are not the same at all, and should be fixed before a >> future com

Re: RFR: 8304717: Declaration aliasing between boolean and jboolean is wrong [v3]

2023-04-06 Thread Phil Race
On Fri, 31 Mar 2023 05:57:01 GMT, Julian Waters wrote: >> A couple of spots wrongly refer to boolean and jboolean as the same thing. >> While this does still compile thanks to a happy accident and implicit >> conversions, they are not the same at all, and should be fixed before a >> future com

Re: RFR: 8304717: Declaration aliasing between boolean and jboolean is wrong [v3]

2023-03-30 Thread David Holmes
On Fri, 31 Mar 2023 05:57:01 GMT, Julian Waters wrote: >> A couple of spots wrongly refer to boolean and jboolean as the same thing. >> While this does still compile thanks to a happy accident and implicit >> conversions, they are not the same at all, and should be fixed before a >> future com

Re: RFR: 8304717: Declaration aliasing between boolean and jboolean is wrong [v3]

2023-03-30 Thread Julian Waters
On Fri, 24 Mar 2023 03:02:47 GMT, David Holmes wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Explicit conversion to jboolean > > src/java.prefs/macosx/native/libprefs/MacOSXPreferencesFile.m line 685: > >> 683:

Re: RFR: 8304717: Declaration aliasing between boolean and jboolean is wrong [v3]

2023-03-30 Thread Julian Waters
> A couple of spots wrongly refer to boolean and jboolean as the same thing. > While this does still compile thanks to a happy accident and implicit > conversions, they are not the same at all, and should be fixed before a > future compiler error happens if their declarations are touched Julian