On Fri, 21 Apr 2023 16:22:02 GMT, Naoto Sato wrote:
>> The current macro assumes the argument is `jint` because all locations pass
>> `jint`. However, this would not work if a wider type such as `jlong` is
>> passed. Removing the `unsigned` cast and make the condition explicit would
>> make th
On Fri, 21 Apr 2023 12:42:24 GMT, David Schlosnagle wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/jni_util.c
>>
>> Co-authored-by: David Schlosnagle
>
> src/java.base
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the macro more robust.
Naoto Sato has updated the pull requ
On Thu, 20 Apr 2023 18:39:29 GMT, Naoto Sato wrote:
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the ma
On Thu, 20 Apr 2023 18:39:29 GMT, Naoto Sato wrote:
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the ma
The current macro assumes the argument is `jint` because all locations pass
`jint`. However, this would not work if a wider type such as `jlong` is passed.
Removing the `unsigned` cast and make the condition explicit would make the
macro more robust.
-
Commit messages:
- 8304836:
