On Mon, 3 Apr 2023 22:32:44 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class b
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Mon, 3 Apr 2023 21:05:07 GMT, Rémi Forax wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Jorn Vernee
>
> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 199:
>
>> 197:
On Mon, 3 Apr 2023 20:24:56 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class b
On Mon, 3 Apr 2023 20:24:56 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class b
On Mon, 3 Apr 2023 19:41:28 GMT, Jorn Vernee wrote:
>> I see your point. If it were a static counter for all dumpers,
>> multiple`.failed-xxx` dumped by a single dumper may not be in sequence if
>> other dumpers have `.failed-xxx` class files.
>
> If the counter has to be per dumper, maybe i
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Mon, 3 Apr 2023 19:26:13 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2536:
>>
>>> 2534: }
>>> 2535: } else {
>>> 2536: name += ".failed-" +
>>> dumper.increment
On Mon, 3 Apr 2023 19:21:00 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 115:
>>
>>> 113: if (dumper.isEnabled() && !path.equals(dumper.dumpPath())) {
>>> 114: throw new IllegalArgumentException("mismatched dump path
>>>
On Mon, 3 Apr 2023 18:13:54 GMT, Jorn Vernee wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> set -D or -D=true will enable dumping
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2536:
>
>>
On Mon, 3 Apr 2023 18:07:52 GMT, Jorn Vernee wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> set -D or -D=true will enable dumping
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>
On Thu, 30 Mar 2023 18:46:25 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Wed, 29 Mar 2023 02:10:10 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Tue, 28 Mar 2023 21:51:21 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - move ClassFileDumper to jdk.internal.util
>> - rename the system property for dumping class files
>
> src/java.base/sh
On Mon, 27 Mar 2023 21:12:28 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Sun, 26 Mar 2023 18:41:12 GMT, Brian Goetz wrote:
> Since LMF goes through Lookup::defineHiddenClass, does this mean that they
> will be potentially dumped twice, once through Lookup, and once through LMF?
No, only once. The old dumping code in LMF is removed.
> Now that there is a shared
Since LMF goes through Lookup::defineHiddenClass, does this mean that
they will be potentially dumped twice, once through Lookup, and once
through LMF?
Now that there is a shared implementation, perhaps we should migrate use
in LMF to something more like
-Djava.lang.invoke.MethodHandle.DU
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Fri, 24 Mar 2023 20:54:25 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> avoid another map lookup
>
> src/java.base/share/classes/java/lang/invoke/ClassFileDumper.java line 88:
>
>> 86:
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Fri, 24 Mar 2023 20:41:41 GMT, Mandy Chung wrote:
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class byte
This implements a shared utility to dump generated classes defined as
normal/hidden classes via `Lookup` API. This replaces the implementation in
`LambdaMetaFactory` and method handle implementation that dumps the hidden
class bytes on disk for debugging.
For classes defined via `Lookup::d
29 matches
Mail list logo
