> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Thu, 30 Mar 2023 18:46:25 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Mon, 3 Apr 2023 18:07:52 GMT, Jorn Vernee wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> set -D or -D=true will enable dumping
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>
On Mon, 3 Apr 2023 18:13:54 GMT, Jorn Vernee wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> set -D or -D=true will enable dumping
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2536:
>
>>
On Mon, 3 Apr 2023 19:21:00 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 115:
>>
>>> 113: if (dumper.isEnabled() && !path.equals(dumper.dumpPath())) {
>>> 114: throw new IllegalArgumentException("mismatched dump path
>>>
On Mon, 3 Apr 2023 19:26:13 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2536:
>>
>>> 2534: }
>>> 2535: } else {
>>> 2536: name += ".failed-" +
>>> dumper.increment
On Mon, 3 Apr 2023 19:41:28 GMT, Jorn Vernee wrote:
>> I see your point. If it were a static counter for all dumpers,
>> multiple`.failed-xxx` dumped by a single dumper may not be in sequence if
>> other dumpers have `.failed-xxx` class files.
>
> If the counter has to be per dumper, maybe i
