Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v4]

2023-05-09 Thread Roger Riggs
On Tue, 9 May 2023 09:03:09 GMT, Mandy Chung wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct Platform.is64Bit() to report address size of the architecture >> enum, not the running system > >

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v4]

2023-05-09 Thread Roger Riggs
On Tue, 9 May 2023 11:16:32 GMT, Glavo wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct Platform.is64Bit() to report address size of the architecture >> enum, not the running system > >

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v5]

2023-05-09 Thread Roger Riggs
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report errors via exceptions. > > Neither os.name nor os.arch

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v4]

2023-05-09 Thread Glavo
On Mon, 8 May 2023 14:53:41 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v4]

2023-05-09 Thread Mandy Chung
On Mon, 8 May 2023 14:53:41 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v4]

2023-05-08 Thread Roger Riggs
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report errors via exceptions. > > Neither os.name nor os.arch

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-07 Thread Mandy Chung
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-07 Thread Mandy Chung
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-06 Thread Alan Bateman
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Jaikiran Pai
On Fri, 5 May 2023 14:10:42 GMT, Roger Riggs wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 71: >> >>> 69: */ >>> 70: public static Platform runtime() { >>> 71: return new Platform(OperatingSystem.current(), >>> Architecture.current()); >>

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Jaikiran Pai
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Roger Riggs
On Thu, 4 May 2023 12:36:32 GMT, Jaikiran Pai wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Source code cleanup suggested by reviewers > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Roger Riggs
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report errors via exceptions. > > Neither os.name nor os.arch

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v2]

2023-05-05 Thread Alan Bateman
On Thu, 4 May 2023 20:37:31 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v2]

2023-05-05 Thread Jaikiran Pai
On Thu, 4 May 2023 20:37:31 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v2]

2023-05-04 Thread Roger Riggs
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report errors via exceptions. > > Neither os.name nor os.arch

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink

2023-05-04 Thread Jaikiran Pai
On Fri, 21 Apr 2023 17:06:44 GMT, Roger Riggs wrote: > Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink

2023-05-04 Thread Jaikiran Pai
On Fri, 21 Apr 2023 17:06:44 GMT, Roger Riggs wrote: > Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink

2023-05-04 Thread Jaikiran Pai
On Thu, 4 May 2023 12:27:26 GMT, Jaikiran Pai wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to

RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink

2023-05-03 Thread Roger Riggs
Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem and Architecture instead of os.name and os.arch. They are direct replacements for the Platform enums except for UNKNOWN; its use is refactored to report errors via exceptions. Neither os.name nor os.arch should be