On Thu, 6 Apr 2023 03:43:26 GMT, Quan Anh Mai wrote:
>> Thank you for doing this. I am guessing it was always intended to be public
>> but was not spotted in previous reviews.
>
> @PaulSandoz Thanks for your timely review, do I need a second review for this
> patch?
Hello @merykitty,
I'm
On Tue, 4 Apr 2023 15:44:41 GMT, Paul Sandoz wrote:
>> Hi,
>>
>> This patch adds `VectorMask.xor` to the public interface of `VectorMask`.
>> This method has already been existed in each concrete mask classes.
>>
>> Please kindly review.
>> Thanks a lot.
>
> Thank you for doing this. I am
On Tue, 4 Apr 2023 15:44:41 GMT, Paul Sandoz wrote:
>> Hi,
>>
>> This patch adds `VectorMask.xor` to the public interface of `VectorMask`.
>> This method has already been existed in each concrete mask classes.
>>
>> Please kindly review.
>> Thanks a lot.
>
> Thank you for doing this. I am
On Sat, 1 Apr 2023 15:40:14 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch adds `VectorMask.xor` to the public interface of `VectorMask`.
> This method has already been existed in each concrete mask classes.
>
> Please kindly review.
> Thanks a lot.
Thank you for doing this. I am guessing it
Hi,
This patch adds `VectorMask.xor` to the public interface of `VectorMask`. This
method has already been existed in each concrete mask classes. Also, this patch
renames `VectorMask.eq` to `VectorMask::xorNot`, which is more consistent with
other logical operations in the same interface.