Re: RFR: 8305505: NPE in javazic compiler [v2]

2023-04-26 Thread Naoto Sato
On Wed, 26 Apr 2023 03:03:58 GMT, Yoshiki Sato wrote: >> Please review this PR. >> With this minor change, the javazic compiler (Main.java) can produce the >> HTML files that display given time zone data correctly. > > Yoshiki Sato has updated the pull request incrementally with one additional

Re: RFR: 8305505: NPE in javazic compiler [v2]

2023-04-25 Thread Yoshiki Sato
> Please review this PR. > With this minor change, the javazic compiler (Main.java) can produce the HTML > files that display given time zone data correctly. Yoshiki Sato has updated the pull request incrementally with one additional commit since the last revision: Insert null check for map

Re: RFR: 8305505: NPE in javazic compiler

2023-04-25 Thread Naoto Sato
On Tue, 18 Apr 2023 05:08:35 GMT, Yoshiki Sato wrote: > Please review this PR. > With this minor change, the javazic compiler (Main.java) can produce the HTML > files that display given time zone data correctly. I revisited the code, and now think that `mapList` better be `null`, as it indic

Re: RFR: 8305505: NPE in javazic compiler

2023-04-24 Thread Yoshiki Sato
On Tue, 18 Apr 2023 19:50:59 GMT, Naoto Sato wrote: >> Please review this PR. >> With this minor change, the javazic compiler (Main.java) can produce the >> HTML files that display given time zone data correctly. > > test/jdk/sun/util/calendar/zi/GenDoc.java line 159: > >> 157: if

RFR: 8305505: NPE in javazic compiler

2023-04-24 Thread Yoshiki Sato
Please review this PR. With this minor change, the javazic compiler (Main.java) can produce the HTML files that display given time zone data correctly. - Commit messages: - Remove trailing spaces - Fix a mistake in the change - 8305505: NPE in javazic compiler Changes: https://

Re: RFR: 8305505: NPE in javazic compiler

2023-04-24 Thread Naoto Sato
On Tue, 18 Apr 2023 05:08:35 GMT, Yoshiki Sato wrote: > Please review this PR. > With this minor change, the javazic compiler (Main.java) can produce the HTML > files that display given time zone data correctly. test/jdk/sun/util/calendar/zi/GenDoc.java line 159: > 157: if (mapLi