Re: RFR: 8306038: SystemModulesPlugin: Keep stack clean

2023-04-16 Thread Oliver Kopp
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote: > This refs [https://bugs.openjdk.org/browse/JDK-8306038](8306038). > > (Before this referenced 8240567) > > Although this change is rather small, I think, it's good to have a "more > clean" SystemModulesPlugin available. Thank you for cre

Re: RFR: 8306038: SystemModulesPlugin: Keep stack clean

2023-04-17 Thread Alan Bateman
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote: > This refs [https://bugs.openjdk.org/browse/JDK-8306038](8306038). > > (Before this referenced 8240567) > > Although this change is rather small, I think, it's good to have a "more > clean" SystemModulesPlugin available. This looks okay.

Re: RFR: 8306038: SystemModulesPlugin: Keep stack clean

2023-04-18 Thread Oliver Kopp
On Mon, 17 Apr 2023 08:21:11 GMT, Alan Bateman wrote: > This looks right. I assume you've checked `java > -XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal -version` as > this code is not normally verified koppor@DESKTOP-KAK953S /cygdrive/c/git-repositories/jdk/jdk/build/windows-

Re: RFR: 8306038: SystemModulesPlugin: Keep stack clean

2023-04-18 Thread Mandy Chung
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote: > This refs [https://bugs.openjdk.org/browse/JDK-8306038](8306038). > > (Before this referenced 8240567) > > Although this change is rather small, I think, it's good to have a "more > clean" SystemModulesPlugin available. or you can just r

Re: RFR: 8306038: SystemModulesPlugin: Keep stack clean

2023-04-18 Thread Mandy Chung
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote: > This refs [https://bugs.openjdk.org/browse/JDK-8306038](8306038). > > (Before this referenced 8240567) > > Although this change is rather small, I think, it's good to have a "more > clean" SystemModulesPlugin available. I ran tier1-tier3

Re: RFR: 8306038: SystemModulesPlugin: Keep stack clean

2023-04-19 Thread Alan Bateman
On Tue, 18 Apr 2023 19:42:23 GMT, Mandy Chung wrote: > I ran tier1-tier3 tests with your patch and all passed. Good. @koppor You can edit the PR title to match the JBS issue, then enter "/integrate" and one of us will sponsor. - PR Comment: https://git.openjdk.org/jdk/pull/13442#i