Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-27 Thread Alan Bateman
On Thu, 27 Jul 2023 06:07:42 GMT, David Holmes wrote: >> Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception >> will be printed and it will exit with 1; if there is no pending exception >> then it exit with the value of `ret` as the exit status, which will be 0 >> here. >

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-27 Thread David Holmes
On Thu, 27 Jul 2023 05:45:59 GMT, Alan Bateman wrote: >> I am not incredibly familiar with the java launcher but I believe what I >> have is a mistake. I will change it to `CHECK_EXCEPTION_LEAVE(1)` instead. > > Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception will > be

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-26 Thread Alan Bateman
On Wed, 26 Jul 2023 21:52:04 GMT, Matias Saavedra Silva wrote: >> src/java.base/share/native/libjli/java.c line 464: >> >>> 462: if (dumpSharedSpaces) { >>> 463: CHECK_EXCEPTION_LEAVE(0); >>> 464: LEAVE(); >> >> What is exit status ($?) when -Xshare:dump fails. It looks like

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-26 Thread Matias Saavedra Silva
On Wed, 26 Jul 2023 18:52:41 GMT, Alan Bateman wrote: >> Matias Saavedra Silva has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains five commits: >> >> - Merge fix >> - Restores java loaders >> - Ioi and David comments >> -

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-26 Thread Alan Bateman
On Tue, 25 Jul 2023 18:48:58 GMT, Matias Saavedra Silva wrote: >> Currently we exit the VM after static dumping with >> `MetaspaceShared::exit_after_static_dump()`. >> >> >> // We have finished dumping the static archive. At this point, there may be >> pending VM >> // operations. We

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-26 Thread Ioi Lam
On Tue, 25 Jul 2023 18:48:58 GMT, Matias Saavedra Silva wrote: >> Currently we exit the VM after static dumping with >> `MetaspaceShared::exit_after_static_dump()`. >> >> >> // We have finished dumping the static archive. At this point, there may be >> pending VM >> // operations. We

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-25 Thread Matias Saavedra Silva
> Currently we exit the VM after static dumping with > `MetaspaceShared::exit_after_static_dump()`. > > > // We have finished dumping the static archive. At this point, there may be > pending VM > // operations. We have changed some global states (such as > vmClasses::_klasses) that > //