On Tue, 9 May 2023 16:08:57 GMT, Chen Liang wrote:
>> To make this runnable without manually adding a bunch of `--add-opens` flags
>
> They are added in the `make/RunTests.gmk`:
> https://github.com/openjdk/jdk/pull/13550/files#diff-041bf69ea79b333b9ce99c1f879e398d698538530a35c361500b72631f05923
On Tue, 9 May 2023 16:09:14 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is caching
On Tue, 9 May 2023 15:57:44 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 42:
>>
>>> 40: @BenchmarkMode(Mode.Throughput)
>>> 41: @State(Scope.Benchmark)
>>> 42: @Fork(value = 1, jvmArgsAppend = {"--enable-preview"})
>>
>> Suggestion:
>>
On Tue, 9 May 2023 15:50:30 GMT, Claes Redestad wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed StackMapGenerator
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 42:
>
>> 40: @Ben
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in `NameAndT
