On Mon, 15 May 2023 17:04:54 GMT, Claes Redestad wrote:
>> I'm not questioning performance differences between list implementations.
>> The implementation of top level list for this benchmark is irrelevant
>> because ~10ns difference cannot affect ~100µs benchmark run.
>
> Fair point. The only
On Mon, 15 May 2023 14:34:13 GMT, Adam Sotona wrote:
>> I have to side with @liach here: `LinkedList` iteration is significantly
>> slower than `ArrayList` even though the computational complexity is
>> identical. Often by an integer factor. This is due to the sparseness of the
>> linked list
On Mon, 15 May 2023 13:42:05 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>>
>>> 55: public void setup() throws IOException {
>>> 56: shared = new LinkedList<>();
>>> 57: unshared = new LinkedList<>();
>>
>> Linke
On Fri, 12 May 2023 13:19:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed jmh benchmark parameters
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>
>> 55:
On Fri, 12 May 2023 13:19:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed jmh benchmark parameters
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>
>> 55:
On Wed, 10 May 2023 10:00:47 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is caching
On Wed, 10 May 2023 09:55:13 GMT, Adam Sotona wrote:
>> That seems misplaced. Please file an RFE to have this cleaned up.
>>
>> Each microbenchmark that has to add opens needs to take responsibility for
>> that themselves and not change the environment for everything else. And all
>> micros t
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in `NameAndT
On Tue, 9 May 2023 16:15:27 GMT, Claes Redestad wrote:
>> They are added in the `make/RunTests.gmk`:
>> https://github.com/openjdk/jdk/pull/13550/files#diff-041bf69ea79b333b9ce99c1f879e398d698538530a35c361500b72631f059233R599-R608
>
> That seems misplaced. Please file an RFE to have this cleaned
