Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 17:40:58 GMT, Mandy Chung wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> newline at end of test file > > test/jdk/java/net/URL/HandlersPkgPrefix/LargeClasspathWithPkgPrefix.java line > 115: >

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 16:42:21 GMT, Alan Bateman wrote: > I wouldn't normally suggest dropping an import and using a qualified class > name but "Handler" is a very generic class name, replacing it with "new > sun.net.www.protocol.jar.Handler()" might be clearer. I agree. I have now updated the PR

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Mandy Chung
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8308184? >> >> When an application is launched, the `app` classloader internally uses a >> `jdk.internal.loader.URLCl

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Alan Bateman
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8308184? >> >> When an application is launched, the `app` classloader internally uses a >> `jdk.internal.loader.URLCl

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a > `jdk.internal.loader.URLClassPath` to find and load the main class being > launched.

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 15:01:47 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> newline at end of test file > > src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 186: > >> 184: