Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Adam Sotona
On Thu, 12 Oct 2023 11:11:10 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed obsolete exports from BuildMicrobenchmark.gmk > >

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Maurizio Cimadamore
On Wed, 11 Oct 2023 07:17:04 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Magnus Ihse Bursie
On Thu, 12 Oct 2023 10:40:03 GMT, Adam Sotona wrote: >> make/test/BuildMicrobenchmark.gmk line 99: >> >>> 97: JAVAC_FLAGS := --add-exports >>> java.base/sun.security.util=ALL-UNNAMED \ >>> 98: --add-exports java.base/sun.invoke.util=ALL-UNNAMED \ >>> 99: --add-exports

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Adam Sotona
On Thu, 12 Oct 2023 10:23:56 GMT, Magnus Ihse Bursie wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed obsolete exports from BuildMicrobenchmark.gmk > > make/test/BuildMicrobenchmark.gmk line 99: > >> 97:

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Magnus Ihse Bursie
On Wed, 11 Oct 2023 07:17:04 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-11 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR