On Wed, 24 May 2023 13:44:40 GMT, Martin Doerr wrote:
>> Do you prefer removing it?
>
> I think it's not important. I'll just integrate it to get the tests working
> again.
Yeah, let's integrate
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204172106
On Wed, 24 May 2023 12:56:55 GMT, Martin Doerr wrote:
>> It's probably not required. It was derived from a jextract generated file.
>
> Do you prefer removing it?
I think it's not important. I'll just integrate it to get the tests working
again.
-
PR Review Comment:
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote:
> Please review this trivial adaptation for JDK-8308276.
Marked as reviewed by mbaesken (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14116#pullrequestreview-1441800497
On Wed, 24 May 2023 12:48:00 GMT, Martin Doerr wrote:
>> test/jdk/java/foreign/TestHFA.java line 53:
>>
>>> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup();
>>> 52:
>>> 53: static final OfFloat FLOAT = JAVA_FLOAT.withByteAlignment(4);
>>
>> Is this even required -
On Wed, 24 May 2023 12:12:25 GMT, Maurizio Cimadamore
wrote:
>> Please review this trivial adaptation for JDK-8308276.
>
> test/jdk/java/foreign/TestHFA.java line 53:
>
>> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup();
>> 52:
>> 53: static final OfFloat FLOAT =
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote:
> Please review this trivial adaptation for JDK-8308276.
Looks good - I apologize for having missed it.
test/jdk/java/foreign/TestHFA.java line 53:
> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup();
> 52:
> 53:
Please review this trivial adaptation for JDK-8308276.
-
Commit messages:
- 8308761: New test TestHFA needs adaptation for JDK-8308276
Changes: https://git.openjdk.org/jdk/pull/14116/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14116=00
Issue:
