Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-08 Thread Adam Sotona
On Thu, 8 Jun 2023 16:35:28 GMT, Brian Goetz wrote: > I have a hard time imagining heavy parallel use here; concurrency against the > same cache would most likely come from accidental sharing.  So this is not > necessarily a problem.  Are you imagining differnet use cases? I think it is common

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-08 Thread Brian Goetz
On Thu, 8 Jun 2023 13:37:33 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-08 Thread Adam Sotona
On Thu, 8 Jun 2023 14:07:24 GMT, Brian Goetz wrote: > Here are a few options:  - Make the CHA cache thread-safe using, say, CHM; This is current solution for the default system CH cache. We may also use a bit less strict custom semi-synchronization (just enough to be thread safe) instead o

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-08 Thread Adam Sotona
From: core-libs-dev on behalf of Brian Goetz Most entities in the system are immutable and therefore freely sharable without additional coordination. Some have lazily-inflated single-field caches that conform to the "benign race" (there is only one possible non-default value) criteria. The

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-08 Thread Brian Goetz
On Thu, 8 Jun 2023 13:37:33 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-08 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >