Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v2]

2023-06-02 Thread Adam Sotona
On Thu, 1 Jun 2023 19:23:05 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/Module.java line 1593: >> >>> 1591: private Class loadModuleInfoClass(InputStream in) throws >>> IOException { >>> 1592: final String MODULE_INFO = "module-info"; >>> 1593: var cc =

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v2]

2023-06-01 Thread Adam Sotona
On Thu, 1 Jun 2023 15:14:52 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed benchmarks > > src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java > line 840: > >> 838:

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v2]

2023-06-01 Thread Adam Sotona
On Thu, 1 Jun 2023 15:04:00 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed benchmarks > > src/java.base/share/classes/java/lang/Module.java line 1593: > >> 1591: private Class loadModuleI

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v2]

2023-06-01 Thread Chen Liang
On Thu, 1 Jun 2023 15:20:27 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v2]

2023-06-01 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >