Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v21]

2023-06-24 Thread Chen Liang
On Wed, 21 Jun 2023 06:29:40 GMT, Adam Sotona wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> ClassfileBenchmark::transformWithNewMaps changed to transformWithAddedNOP > > I think we've resolved controversy about gl

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v21]

2023-06-21 Thread Chen Liang
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected c

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v21]

2023-06-20 Thread Chen Liang
On Wed, 21 Jun 2023 06:50:20 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> ClassfileBenchmark::transformWithNewMaps changed to transformWithAddedNOP > > src/java.base/share/classes/jdk/internal/cla

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v21]

2023-06-20 Thread Chen Liang
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected c

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v21]

2023-06-20 Thread Adam Sotona
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected c

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v21]

2023-06-15 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >